Comments on: Deleting Code

By: James Aguilar

James Aguilar — Thu, 04 Jun 2009 22:08:26 +0000

This was very nice and your other articles seemed good too. I have subscribed to your newsletter.

By: slicedlime

slicedlime — Wed, 03 Jun 2009 19:57:06 +0000

Indeed you’re right… if you compile without the asserts, it’s the worlds longest NOP. That’s a lot easier to see now than at 11 PM on a crunch night though

By: Ryan Graham

Ryan Graham — Wed, 03 Jun 2009 19:36:51 +0000

If none of the functions called have side effects and ASSERT() is a typical debug-only assert, the code does a whole lot of nothing other than exercising the methods used..

By: Sharkey

Sharkey — Wed, 03 Jun 2009 19:36:32 +0000

Assuming no side effects and that the assert is compiled out in a release build, this code does:

Nothing.

By: Ken

Ken — Wed, 03 Jun 2009 19:23:55 +0000

It makes people scroll left-and-right a lot, even if they have a nice big widescreen display?

Ha, just kidding. (But it does.) It ensures the weaponId is in the range [0,8).

By: Rachel Blum

Rachel Blum — Wed, 03 Jun 2009 19:12:55 +0000

Hm. That looks straightforward. Nothing in if (currentTarget && currentTargetSensingData) does anything (assuming your asserts and get functions are side-effect free)

That means you don’t need anything under “always deal with primary object”.

It continues from there, so you have a large heap of do-nothing code

It’s always fun to encounter that… I really wonder what people think when they do this.